use Event#from_json if available #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinsurprenant
changed the title
|
looks good, have the same concern about testing as mentioned here: logstash-plugins/logstash-codec-json_lines#19 (comment) |
|
@talevy I used the same strategy as json_lines, let me know if all good. |
|
|
||
| def from_json_parse(json, &block) | ||
| LogStash::Event.from_json(json).each { |event| yield event } | ||
| rescue LogStash::Json::ParserError => e |
There was a problem hiding this comment.
why no begin block? I prefer the indentation that we get by using the begin, but I also understand it is a bit redundant.
There was a problem hiding this comment.
yup, its a style preference, I actually like no having the extra indentation of the begin! 😉
|
small comment, ott LGTM |
|
thanks, squashing, bumping and merging. |
run specs for both Event#from_json or legacy context if possible
colinsurprenant
force-pushed
the
feature/from_json
branch
from
0e15801
to
52baa87
Compare
|
published 2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/elastic/logstash/pull/4631and elastic/logstash#4595
similar PR as logstash-plugins/logstash-codec-json_lines/pull/19 to support the new
Event#from_jsonif available when using the Java Event.